Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace instances of 'td' with 'th' #193

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace instances of 'td' with 'th' #193

wants to merge 1 commit into from

Conversation

sidward35
Copy link
Contributor

@sidward35 sidward35 commented Oct 2, 2023 •
edited
Loading

Fixes #191 by replacing all instances of td with th in finviz/screener.py.

@PBbanana
Copy link

PBbanana commented Oct 9, 2023

This did NOT fix it for me. What fixed it was to replace 'td' with 'th' only in line 417 of screener.py (in function get_table_headers):

header_elements = self._page_content.cssselect('tr[valign="middle"]')[0].xpath("td")

@mw66
Copy link

mw66 commented Nov 29, 2023

@PBbanana can you create a PR? Thanks.

@mw66 mw66 mentioned this pull request Nov 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Screener data and headers are empty
3 participants
@sidward35 @PBbanana @mw66